Conversation
add init and finalize for custom allocators, raise open file limit, cancel background work, the six built in comparators, and object store connector factories for filesystem and s3 including the full s3 config struct kept header inline so it links against a library built without s3 expose the write amplification counters on column family and database stats, carry the comparator context string through create update save and load, and add the busy error code free caller owned buffers with tidesdb free instead of std free so the binding stays correct under a custom allocator add tests for all of the new surface and fix two stale baseline tests the default max concurrent flushes is zero by design and the tombstone stats test needed a large write buffer so compaction would not purge the tombstones before they could be observed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add init and finalize for custom allocators, raise open file limit, cancel background work, the six built in comparators, and object store connector factories for filesystem and s3 including the full s3 config struct kept header inline so it links against a library built without s3
expose the write amplification counters on column family and database stats, carry the comparator context string through create update save and load, and add the busy error code
free caller owned buffers with tidesdb free instead of std free so the binding stays correct under a custom allocator
add tests for all of the new surface and fix two stale baseline tests the default max concurrent flushes is zero by design and the tombstone stats test needed a large write buffer so compaction would not purge the tombstones before they could be observed