Conversation
| @@ -0,0 +1,34 @@ | |||
|
|
|||
There was a problem hiding this comment.
As with the PR for the thymeleaf code module, please note that Thymeleaf now is in 3.0.14.RELEASE and there is a new 3.1-dev branch which this should be rebased on.
Also note that 3.0.14.RELEASE includes some changes related to restricted mode detection checks that might have made these preliminary classes in the new thymeleaf-spring6 module outdated.
| @@ -0,0 +1,62 @@ | |||
| /* | |||
There was a problem hiding this comment.
I understand there are still changes to be made to packages here .thymeleaf.spring5. -> .thymeleaf.spring6. -> and also imports on org.thymeleaf.spring5.* classes, right?
| import java.util.Optional; | ||
| import java.util.TimeZone; | ||
|
|
||
| import jakarta.servlet.http.HttpServletRequest; |
There was a problem hiding this comment.
See how, in the whole code submitted here for the new thymeleaf-spring6 module, there are only two instances of imports on jakarta.* classes. This kind of makes me think that the effect on code complexity of performing the org.thymeleaf.web.servlet.* generalisation I mentioned for the core module might not be that bad…
There was a problem hiding this comment.
Are you thinking we would try to have the same code base between spring 5 and 6? Having the same code base for Spring 5 & 6 seems to deviate from the pattern that is currently established and I think it would likely end up making things difficult to maintain.
There was a problem hiding this comment.
No no, I didn't mean that. I believe these should still be different modules. I was just reflecting on the fact that, after all, use of native javax.servlet characteristics is not very extense in these modules, so the abstraction of these entities would not really bring a lot of changes to them.
2 participants
Add preliminary support for Spring Framework 6 which requires Jakarta EE. This PR is dependent on thymeleaf/thymeleaf#856