Skip to content

Enhance error handling in all package required routes #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 11-19-_ts-api-react-actions_enhance_error_handling_in_api_actions_and_hooks_with_user-facing_error_mapping
Choose a base branch
from
Draft

Enhance error handling in all package required routes #1631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 59 additions & 37 deletions apps/cyberstorm-remix/app/p/tabs/Required/PackageVersionRequired.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,71 +1,89 @@
import {
getPublicEnvVariables,
getSessionTools,
} from "cyberstorm/security/publicEnvVariables";
import { NimbusDefaultRouteErrorBoundary } from "cyberstorm/utils/errors/NimbusErrorBoundary";
import { handleLoaderError } from "cyberstorm/utils/errors/handleLoaderError";
import { throwUserFacingPayloadResponse } from "cyberstorm/utils/errors/userFacingErrorResponse";
import { getLoaderTools } from "cyberstorm/utils/getLoaderTools";
import { parseIntegerSearchParam } from "cyberstorm/utils/searchParamsUtils";
import { Suspense } from "react";
import { type LoaderFunctionArgs } from "react-router";
import { Await, useLoaderData } from "react-router";
import { PaginatedDependencies } from "~/commonComponents/PaginatedDependencies/PaginatedDependencies";

import { SkeletonBox } from "@thunderstore/cyberstorm";
import { DapperTs } from "@thunderstore/dapper-ts";

import { packageDependenciesErrorMappings } from "./Required";

export async function loader({ params, request }: LoaderFunctionArgs) {
if (params.namespaceId && params.packageId && params.packageVersion) {
const publicEnvVariables = getPublicEnvVariables(["VITE_API_URL"]);
const dapper = new DapperTs(() => {
return {
apiHost: publicEnvVariables.VITE_API_URL,
sessionId: undefined,
};
});
const { dapper } = getLoaderTools();
const searchParams = new URL(request.url).searchParams;
const page = searchParams.get("page");
const page = parseIntegerSearchParam(searchParams.get("page"));

return {
version: await dapper.getPackageVersionDetails(
try {
const version = await dapper.getPackageVersionDetails(
params.namespaceId,
params.packageId,
params.packageVersion
),
dependencies: await dapper.getPackageVersionDependencies(
);
const dependencies = await dapper.getPackageVersionDependencies(
params.namespaceId,
params.packageId,
params.packageVersion,
page === null ? undefined : Number(page)
),
};
page
);

return {
version,
dependencies,
};
} catch (error) {
handleLoaderError(error, { mappings: packageDependenciesErrorMappings });
}
}
throw new Response("Package version dependencies not found", { status: 404 });
throwUserFacingPayloadResponse({
headline: "Dependencies not found.",
description: "We could not find the requested version dependencies.",
category: "not_found",
status: 404,
});
}

export async function clientLoader({ params, request }: LoaderFunctionArgs) {
export function clientLoader({ params, request }: LoaderFunctionArgs) {
if (params.namespaceId && params.packageId && params.packageVersion) {
const tools = getSessionTools();
const dapper = new DapperTs(() => {
return {
apiHost: tools?.getConfig().apiHost,
sessionId: tools?.getConfig().sessionId,
};
});
const { dapper } = getLoaderTools();
const searchParams = new URL(request.url).searchParams;
const page = searchParams.get("page");
const page = parseIntegerSearchParam(searchParams.get("page"));

return {
version: dapper.getPackageVersionDetails(
const version = dapper
.getPackageVersionDetails(
params.namespaceId,
params.packageId,
params.packageVersion
),
dependencies: dapper.getPackageVersionDependencies(
)
.catch((error) =>
handleLoaderError(error, { mappings: packageDependenciesErrorMappings })
);
const dependencies = dapper
.getPackageVersionDependencies(
params.namespaceId,
params.packageId,
params.packageVersion,
page === null ? undefined : Number(page)
),
page
)
.catch((error) =>
handleLoaderError(error, { mappings: packageDependenciesErrorMappings })
);

return {
version,
dependencies,
};
}
throw new Response("Package version dependencies not found", { status: 404 });
throwUserFacingPayloadResponse({
headline: "Dependencies not found.",
description: "We could not find the requested version dependencies.",
category: "not_found",
status: 404,
});
}

export default function PackageVersionRequired() {
Expand All @@ -88,3 +106,7 @@ export default function PackageVersionRequired() {
</Suspense>
);
}

export function ErrorBoundary() {
return <NimbusDefaultRouteErrorBoundary />;
}
96 changes: 59 additions & 37 deletions apps/cyberstorm-remix/app/p/tabs/Required/PackageVersionWithoutCommunityRequired.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,71 +1,89 @@
import {
getPublicEnvVariables,
getSessionTools,
} from "cyberstorm/security/publicEnvVariables";
import { NimbusDefaultRouteErrorBoundary } from "cyberstorm/utils/errors/NimbusErrorBoundary";
import { handleLoaderError } from "cyberstorm/utils/errors/handleLoaderError";
import { throwUserFacingPayloadResponse } from "cyberstorm/utils/errors/userFacingErrorResponse";
import { getLoaderTools } from "cyberstorm/utils/getLoaderTools";
import { parseIntegerSearchParam } from "cyberstorm/utils/searchParamsUtils";
import { Suspense } from "react";
import { type LoaderFunctionArgs } from "react-router";
import { Await, useLoaderData } from "react-router";
import { PaginatedDependencies } from "~/commonComponents/PaginatedDependencies/PaginatedDependencies";

import { SkeletonBox } from "@thunderstore/cyberstorm";
import { DapperTs } from "@thunderstore/dapper-ts";

import { packageDependenciesErrorMappings } from "./Required";

export async function loader({ params, request }: LoaderFunctionArgs) {
if (params.namespaceId && params.packageId && params.packageVersion) {
const publicEnvVariables = getPublicEnvVariables(["VITE_API_URL"]);
const dapper = new DapperTs(() => {
return {
apiHost: publicEnvVariables.VITE_API_URL,
sessionId: undefined,
};
});
const { dapper } = getLoaderTools();
const searchParams = new URL(request.url).searchParams;
const page = searchParams.get("page");
const page = parseIntegerSearchParam(searchParams.get("page"));

return {
version: await dapper.getPackageVersionDetails(
try {
const version = await dapper.getPackageVersionDetails(
params.namespaceId,
params.packageId,
params.packageVersion
),
dependencies: await dapper.getPackageVersionDependencies(
);
const dependencies = await dapper.getPackageVersionDependencies(
params.namespaceId,
params.packageId,
params.packageVersion,
page === null ? undefined : Number(page)
),
};
page
);

return {
version,
dependencies,
};
} catch (error) {
handleLoaderError(error, { mappings: packageDependenciesErrorMappings });
}
}
throw new Response("Package version dependencies not found", { status: 404 });
throwUserFacingPayloadResponse({
headline: "Dependencies not found.",
description: "We could not find the requested version dependencies.",
category: "not_found",
status: 404,
});
}

export async function clientLoader({ params, request }: LoaderFunctionArgs) {
export function clientLoader({ params, request }: LoaderFunctionArgs) {
if (params.namespaceId && params.packageId && params.packageVersion) {
const tools = getSessionTools();
const dapper = new DapperTs(() => {
return {
apiHost: tools?.getConfig().apiHost,
sessionId: tools?.getConfig().sessionId,
};
});
const { dapper } = getLoaderTools();
const searchParams = new URL(request.url).searchParams;
const page = searchParams.get("page");
const page = parseIntegerSearchParam(searchParams.get("page"));

return {
version: dapper.getPackageVersionDetails(
const version = dapper
.getPackageVersionDetails(
params.namespaceId,
params.packageId,
params.packageVersion
),
dependencies: dapper.getPackageVersionDependencies(
)
.catch((error) =>
handleLoaderError(error, { mappings: packageDependenciesErrorMappings })
);
const dependencies = dapper
.getPackageVersionDependencies(
params.namespaceId,
params.packageId,
params.packageVersion,
page === null ? undefined : Number(page)
),
page
)
.catch((error) =>
handleLoaderError(error, { mappings: packageDependenciesErrorMappings })
);

return {
version,
dependencies,
};
}
throw new Response("Package version dependencies not found", { status: 404 });
throwUserFacingPayloadResponse({
headline: "Dependencies not found.",
description: "We could not find the requested version dependencies.",
category: "not_found",
status: 404,
});
}

export default function PackageVersionWithoutCommunityRequired() {
Expand All @@ -88,3 +106,7 @@ export default function PackageVersionWithoutCommunityRequired() {
</Suspense>
);
}

export function ErrorBoundary() {
return <NimbusDefaultRouteErrorBoundary />;
}
Loading
Loading