Skip to content

uplift(release): fix: utf8 decoding (#11510) - #11540

Open
wmontwe wants to merge 1 commit into
thunderbird:releasefrom
wmontwe:uplift/release/fix/11508/utf8-decoding
Open

uplift(release): fix: utf8 decoding (#11510)#11540
wmontwe wants to merge 1 commit into
thunderbird:releasefrom
wmontwe:uplift/release/fix/11508/utf8-decoding

Conversation

@wmontwe

@wmontwe wmontwe commented Sep 10, 2026

Copy link
Copy Markdown
Member

Contribution Summary

Linked Issue/Ticket: #11508
Original pull request: #11510

Description

Uplifts the UTF-8 MIME header decoding fix to release. Raw headers are explicitly decoded as UTF-8 instead of relying on Mime4j's ISO-8859-1 toString() behavior. This fixes incorrectly displayed and saved non-ASCII attachment filenames.

Includes the original regression tests for all affected parsing paths.

Testing

  • ./gradlew :mail:common:test :legacy:core:test :mail:common:spotlessCheck :legacy:core:spotlessCheck --no-daemon

Risk

Low. The change is narrowly scoped to raw MIME header decoding and includes regression tests. No localizable strings or database migrations are changed.

AI Disclosure

  • This contribution does not include any changes created or assisted by AI.
  • This contribution includes changes assisted by AI.
  • This contribution includes changes created by AI.

Contribution Checklist

  • I have read and affirm that my contribution adheres to Mozilla's Community Participation Guidelines
  • This contribution is in Kotlin where possible
  • This contribution does not use merge commits
  • This contribution adheres to the existing codestyle
  • This contribution does not break existing unit tests
  • This contribution includes tests for updated functionality
  • This contribution adheres to our Engineering process
  • This PR has a descriptive title and body

@wmontwe
wmontwe requested a review from a team as a code owner September 10, 2026 14:02
@wmontwe
wmontwe requested review from dani-zilla and removed request for a team September 10, 2026 14:02
@github-actions github-actions Bot added the tb-team Tasks and features handled by project maintainers label Sep 10, 2026
@wmontwe

wmontwe commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

[Approval Request]
Original Issue/Pull request: #11508 / #11510
Regression caused by (issue #): #11005
User impact if declined: Non-ASCII attachment filenames continue to be displayed and saved incorrectly on release.
Testing completed (on daily, beta, etc.): Original fix landed on main; targeted unit tests and Spotless checks pass locally on this release uplift branch. The beta uplift is #11539.
Introduces or modifies localizable strings (yes/no): No
Skips a database migration (yes/no): No
Risk to taking this patch (and alternatives if risky): Low. The change is narrowly scoped to raw MIME header decoding and includes regression tests. The alternative is to let the fix ride the release train.

@wmontwe wmontwe added the report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). label Sep 10, 2026
@wmontwe wmontwe removed the tb-team Tasks and features handled by project maintainers label Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants