Skip to content

chore(ci): Build app only on push to main instead of on PR updates - #11522

Closed
coreycb wants to merge 1 commit into
thunderbird:mainfrom
coreycb:build-on-push
Closed

chore(ci): Build app only on push to main instead of on PR updates#11522
coreycb wants to merge 1 commit into
thunderbird:mainfrom
coreycb:build-on-push

Conversation

@coreycb

@coreycb coreycb commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Fixes #11521

@coreycb
coreycb requested a review from a team as a code owner September 8, 2026 14:58
@coreycb coreycb added the report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). label Sep 8, 2026
@coreycb coreycb changed the title Build app only on push to main instead of on PR updates chore(ci): Build app only on push to main instead of on PR updates Sep 8, 2026

@wmontwe wmontwe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the only pre-merge protection against breaking main.

The proposed push build is not an equivalent replacement. It runs only after the change has landed on main. At that point, CI can tell us that main is broken, but it cannot prevent the breakage. Every maintainer who updates their branch, starts new work, or opens another pull request can then encounter the failure until someone investigates and merges a fix or reverts the broken change.

This also transfers the burden from the author of the breaking change to the rest of the team. The failure may be discovered when the author is unavailable, and unrelated pull requests may become blocked or show failures caused by the broken base branch. That creates more disruption and investigation work than allowing CI to validate each update before merge.

The workflow already has:

    cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}                                                                                                                                                                                                    

so superseded runs for a pull request are cancelled.

In my opinion, reducing the number of runs does not justify removing the only pre-merge gate that assembles the applications and runs the unit tests and Android lint.

@coreycb

coreycb commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator Author

I don't disagree. There was concern about the number of builds we're doing. I'll loop you into the conversation.

@coreycb coreycb closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build app only on push to main instead of on each PR update

2 participants