[pull] main from django:main - #547
Merged
Merged
Conversation
…hing. Search terms for non-text `__exact` `search_fields` entries were validated with the model field's `formfield().to_python()`, which failed to reject invalid terms for two kinds of fields: - Fields with choices use `TypedChoiceField`, whose `to_python()` returns the raw string unvalidated, so any non-matching search term (e.g. `"john"` against an `IntegerField` with `choices`) reached the ORM and crashed the changelist with a `ValueError` (HTTP 500). - `BooleanField` uses `forms.BooleanField`, whose `to_python()` maps almost any string to `True`, so an arbitrary search term OR-matched every row with a `True` value instead of matching nothing. Boolean search terms are now parsed such that arbitrary strings do not match anything, and Typed(Multiple)ChoiceField search terms now coerce to the correct types. Regression in 4cecf30. Thanks Adam Johnson for the report and Sarah Boyce for the review. Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )