Update supported versions to reflect state of the world and declare new version#5
Open
lirsacc-mns wants to merge 2 commits intomainfrom
Open
Update supported versions to reflect state of the world and declare new version#5lirsacc-mns wants to merge 2 commits intomainfrom
lirsacc-mns wants to merge 2 commits intomainfrom
Conversation
Author
|
@PeterJCLaw It looks like CI is setup and _should ™️ _ auto release on merge but I don't seem to have access (even with my personal already in the thread org account) so I can't check this or fix it if anything goes wrong. |
71e364e to
eb0d878
Compare
|
^ Force push above - I rewound then re-pushed @lirsacc's commits, purely to trigger CI. CI failure: we don't have the right deploy keys installed in this repo, so Circle can't fetch. |
|
Set up a new deploy key, now blocked on poetry no longer supporting the install approach we're using here. |
|
I suggest we get #6 merged and then rebase on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
<5qualifier is preventing users from upgrading to Django 5.This relaxes the constraint to
<6and generally reflects the state of the world with upward versions and deprecated Python versions.Not making it a breaking major as I don't think dropping out of support python versions counts (otherwise we're doing a major a year for everything by definition).