Skip to content

Conversation

@brliron
Copy link
Member

@brliron brliron commented May 5, 2025

Adds a Github action to upload builds to https://thcrap.thpatch.net/thtk-nightly/thtk-win32-x86.zip and to https://thcrap.thpatch.net/thtk-nightly/thtk-win32-x64.zip

Only pushs to the master branch are uploaded there (the branch name is tested in a small script on the server, I tested using the "deploy-to-thpatch" branch name in that script and then changed it to "master" while writing this pull request).

The main benefit of this is having a permanent storage for nightly builds. Github Action artifacts last for only 60 days, and they definitely did expire a few times in the past.

Also, please merge using "squash and merge". I have that working on CI stuff requires doing a new commit for every single little change.

@DankRank DankRank merged commit acbfbf9 into master May 5, 2025
12 checks passed
@DankRank
Copy link
Member

DankRank commented May 5, 2025

Uh oh it's broken (the files are full of question marks. encoding issue?).

Btw, for testing CI changes I recommend just repeatedly editing the commit (git commit --amend) and force-pushing (git push --force) until it works. That's how I usually do it, though I typically do it on my fork repo.

@brliron
Copy link
Member Author

brliron commented May 5, 2025

Encoding issue sounds likely, I assumed Get-Content params.txt,thtk-bin-ci.zip | ssh would work exactly like cat params.txt thtk-bin-ci.zip | ssh in the unix world, but I've had so many encoding issues with various things that I can easily believe having another one there. Btw, one of these issues was an UTF-8 BOM that, when I think about it, probably comes from this Get-Content command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants