fix: use chain.logo instead of getNetworkIconUrl in NetworkGrid#266
Open
markshenouda wants to merge 1 commit intofeat/dev-3.0-no-landingfrom
Open
fix: use chain.logo instead of getNetworkIconUrl in NetworkGrid#266markshenouda wants to merge 1 commit intofeat/dev-3.0-no-landingfrom
markshenouda wants to merge 1 commit intofeat/dev-3.0-no-landingfrom
Conversation
Testnet chain display names (e.g. 'Ethereum Sepolia') were being normalized to CDN paths that don't exist (e.g. ethereum-sepolia.svg). Mainnet names (e.g. 'Ethereum') happened to match CDN filenames. getAllNetworks already computes the correct logo via getChainIcon, so use chain.logo directly and remove the getNetworkIconUrl call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testnet chain display names (e.g. 'Ethereum Sepolia') were being normalized to CDN paths that don't exist (e.g. ethereum-sepolia.svg). Mainnet names (e.g. 'Ethereum') happened to match CDN filenames.
getAllNetworks already computes the correct logo via getChainIcon, so use chain.logo directly and remove the getNetworkIconUrl call.