Tool window: tabs across the four views, maximize, one rail - #123
Merged
Merged
Conversation
The window Library, Algorithms, Grammar and Reference share had a title bar that named the open view and offered only a close button, so moving between views meant closing the window and reopening it from the More menu. Its bar is now a tab strip across the four, Library first, built from AUX_META so a view is named and iconed in one place. - Tabs: roving tabindex, Arrow/Home/End, the old subtitle as each tab's tooltip with its shortcut. AUX_VIEWS is the order of the strip, the More menu and the digits; auxViewKey() derives the digit from the position, so Library is now 2 and the tools 3-5. - Maximize: a toggle (aria-pressed), remembered per reader, desktop only; double-clicking the bar does the same. No minimize - every view already keeps its place when closed. - The canvas machine is named in the bar while Algorithms is open. - The four rails share one width and one row face (they were 200, 208, 190 and 190px, two of them inline, in two different fonts). - Close hovers neutral rather than red. - Empty-canvas messages pointed at a Build tab that no longer exists; they now offer a Back to canvas button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HPVKDwzQWjyqE1nApBQt6s
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window that Library, Algorithms, Grammar and Reference share had a title bar that only named the open view and offered a close button. To get from one view to another you had to close the window and reopen it from the More menu. This PR turns the window's bar into a tab strip and makes the four views look like parts of one window.
What changed
Tab strip in the bar. The bar now holds four tabs, in this order: Library, Algorithms, Grammar, Reference.
AUX_META, so each view's name and icon are defined in one place.bridge.js.Shortcut keys follow the tab order.
AUX_VIEWSsets the order for the strip, the More menu's Explore group and the number-key shortcuts.auxViewKey()works out each view's key from its position. Because Library moved to the front, the keys change: Library is now 2, Algorithms 3, Grammar 4, Reference 5. Before, they were Algorithms 2, Grammar 3, Reference 4, Library 5.Maximize.
aria-pressed.automata-aux-max. It is desktop only, since below 900px the window is already full-screen.Which machine Algorithms will use. While Algorithms is open, the bar shows the machine on the canvas, for example
DFA · 5 states · 7 transitions. The canvas is hidden behind the window, so this was otherwise only visible after closing it.One shape for the four side menus. They were 200, 208, 190 and 190px wide (two set with inline styles) and used two different fonts, so the menu's edge jumped when switching between views. They now share one width (
--aux-rail-w), one row style in sans, and one group-heading style.Smaller fixes
Testing
npm test: 2621 passed, 0 failed. This includes the newtests/aux-window.test.js, which covers the tab order and selection, the arrow keys, Library being first with the More menu and keys in the same order, maximize being remembered, the machine label, and the single menu width.npm run buildsucceeds.Worth trying by hand: switching between tabs on a machine you've built, maximize on a large monitor, and the new number keys. If you'd rather keep the old key numbers, I can revert that part.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HPVKDwzQWjyqE1nApBQt6s
Generated by Claude Code