Put automata on PATH from the installers - #117
Merged
Merged
Conversation
- Windows: the NSIS installer adds resources\cli to the user's PATH and the uninstaller removes it (build/installer.nsh), skipping the removal during an update. The editing is done by build/win/cli-path.ps1 against HKCU\Environment directly, keeping %VARIABLE% entries unexpanded and the value's kind, never listing the folder twice, and removing only its own entry. NSIS itself would truncate a PATH longer than 1024 characters. - Linux (.deb): after-install links /usr/local/bin/automata, after-remove takes it away; an automata already there is left alone. The scripts carry electron-builder's own defaults, which a custom script replaces. - macOS: Install/Uninstall 'automata' Command in PATH in the app menu, linking /usr/local/bin/automata, with an admin prompt only when needed, and a refusal while the app runs translocated from the disk image. - The POSIX launcher follows symlinks itself: readlink -f is missing before macOS 12.3. - CI installs the real Windows and .deb packages, runs automata from PATH, uninstalls and checks it is gone; on macOS it runs the launcher through a chain of relative links.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installers now put the
automatacommand line on PATH.resources\clito the user's PATH, and the uninstaller removes it. It leaves PATH alone during an update. The PATH editing is inbuild/win/cli-path.ps1, which works onHKCU\Environmentdirectly. That keeps%VAR%entries unexpanded and never truncates a long PATH./usr/local/bin/automata, and removing the package takes the link away. An existingautomatathere is left alone. The scripts carry electron-builder's default steps, because a custom script replaces them.readlink -fis missing before macOS 12.3.automatafrom PATH, uninstalls, and checks it's gone. On macOS it runs the launcher through a chain of links.docs/cli.mdInstall section updated.Not covered by CI: the macOS menu items, which need a click on a real Mac.