Repository navigation
fix(render): draw other players' name tags without the show-name flags - #66
Merged
notchyves merged 1 commit intoNov 6, 2026
Merged
Conversation
Players only got a name tag when their flags carried CAN_SHOW_NAME (bit 14) or ALWAYS_SHOW_NAME (bit 15). Servers often send neither while still setting a name tag, and the game draws it anyway, so every other player's name was missing there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On The Hive, Perlin draws no name tag above other players, only your own.
Cause
EntityRendereronly allowed a player's name tag when its actor flags hadCAN_SHOW_NAME(bit 14) orALWAYS_SHOW_NAME(bit 15):That rule came in with a merge (
58e5986) and was never checked against the vanilla client.Evidence
The evidence is a packet capture (Perlin
packetlog) of a Hive hub withPERLIN_DEBUG_NAMETAGS=1: 38add_playerand 91 playeradd_player/set_entity_datarecords with metadata. None of them sets bit 14 or 15, but every one carries a name tag:1970359197237248(most players)§7Robino1000,§7Sumpkin619\n§9 3669 Total Kills1970359197237256(sneaking players)§7gamer nolan 203\n§eThe §bSky Warrior1970496636190720(our own player)§7NaykuuMc\n§cThe Defender1688884220002304(shop NPCs added as players)§a§lSteampunk Wings§r\n§e490…\n§r§7Tap to viewThe vanilla client shows all of these names on that server, so it does not require the show-name flags for players. Perlin drew only one player name tag in the whole capture: our own, which bypassed the rule through
isSelf.Change
EntityRenderer.cpp: thenameAllowedgate is removed. Everything else stays as it was:Testing