Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 15 15
Lines 1693 1895 +202
==========================================
+ Hits 1693 1895 +202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theory
force-pushed
the
select-any-slice-or-map
branch
8 times, most recently
from
2d49c4c to
85862f7
Compare
Turns out to be more straightforward than I expected to support selecting values not just from `[]any` and `map[string]any` but from any type of slice or string-keyed map, thanks to the `reflect` package. Leave the branches for `[]any` and `map[string]any` in place to avoid the overhead of reflection, but then use reflection if the value is any other type of slice or map. Resolves #26.
theory
force-pushed
the
select-any-slice-or-map
branch
from
0ed088b to
6e9665f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out to be more straightforward than I expected to support selecting values not just from
[]anyandmap[string]anybut from any type of slice or string-keyed map, thanks to thereflectpackage.Leave the branches for
[]anyandmap[string]anyin place to avoid the overhead of reflection, but then use reflection if the value is any other type of slice or map. Resolves #26.