Correct breaking change description in commit history#16
Closed
Copilot wants to merge 2 commits intochore/update-dataset-wrapperfrom
Closed
Correct breaking change description in commit history#16Copilot wants to merge 2 commits intochore/update-dataset-wrapperfrom
Copilot wants to merge 2 commits intochore/update-dataset-wrapperfrom
Conversation
The previous commit message stated "BREAKING CHANGE: remove match methods from DatasetCoreBase" but this was inaccurate. The actual breaking changes were: - BREAKING CHANGE: Removed `matchSubjectsOf` method from `DatasetWrapper` - BREAKING CHANGE: Removed `matchObjectsOf` method from `DatasetWrapper` The `match` method in `DatasetCoreBase` was NOT removed and remains unchanged. The removed methods were replaced with simpler `subjectsOf` and `objectsOf` methods that internally use a `toTerm` helper function for better code clarity. Fixes the PR description mismatch noted in review feedback.
Copilot
AI
changed the title
[WIP] Update dataset wrapper based on feedback from PR #14
Correct breaking change description in commit history
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1407704 incorrectly states "BREAKING CHANGE: remove match methods from DatasetCoreBase" but the actual changes removed
matchSubjectsOfandmatchObjectsOffromDatasetWrapper. Thematchmethod inDatasetCoreBaseremains unchanged.Changes
matchSubjectsOffromDatasetWrappermatchObjectsOffromDatasetWrappersubjectsOfandobjectsOfmethods usingtoTermhelperThis ensures the changelog accurately reflects what was modified.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.