Conversation
Co-authored-by: Copilot <copilot@github.com>
- Create _toast.scss token file with var()-wrapped design variables - Add toast.scss as standalone entry point for runtime-injected styles - Refactor _toast.scss component to use SCSS token variables - Remove redundant :root CSS variable declarations
- Add TutorToastTheme type ('light' | 'dark' | 'auto')
- Default to 'auto' in runtime, 'light' in React ToastProvider
- Theme applied via data-tutor-theme attribute on container
- Improve createContextBound type safety with ToastContextOptions
- Clean up barrel exports to only expose React API
… ToastService - Remove dead re-exports (createTutorToastApi, tutorToastDefaults, etc.) - Remove empty constructor that called configure with defaults
- Migrate imports to use @Core/ts/toast barrel export - Add ToastProvider to all app root components with theme="light" - Update service files to use useToast hook from shared module
- Register toast.scss as standalone CSS entry in rspack config - Enqueue toast CSS separately from main core stylesheet - Add styles.d.ts type declaration for SCSS module imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.