Skip to content

fix(server): only emit ANSI log colors when stdout is a TTY #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thejefflarson merged 1 commit into from
Jul 19, 2026
Merged

fix(server): only emit ANSI log colors when stdout is a TTY #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion server/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use std::io::IsTerminal;
use std::net::SocketAddr;

use opentelemetry::trace::TracerProvider as _;
Expand Down Expand Up @@ -58,7 +59,15 @@ async fn main() -> anyhow::Result<()> {
EnvFilter::try_from_default_env()
.unwrap_or_else(|_| EnvFilter::new("info,watcher_server=debug,sqlx=warn")),
)
.with(tracing_subscriber::fmt::layer())
// Only colorize when stdout is a real terminal. Under Kubernetes (and any
// piped/redirected stdout) the fmt layer's default ANSI-on would otherwise
// litter the pod logs with raw `\x1b[..m` escape sequences. `NO_COLOR`
// (https://no-color.org) force-disables it regardless.
.with(
tracing_subscriber::fmt::layer().with_ansi(
std::io::stdout().is_terminal() && std::env::var_os("NO_COLOR").is_none(),
),
)
.with(otel_layer)
.init();

Expand Down