Repository navigation
deps: clear 13 RUSTSEC advisories to make cargo audit green - #355
Merged
Merged
Conversation
The `test` CI job's "Audit dependencies" step was red repo-wide: 13 vulnerabilities fired on transitive deps. Every one had a reachable fix, so this bumps rather than ignores (no new audit.toml entries). Lockfile-only, except one direct-dep version req in engine/Cargo.toml: - rustls 0.23.41 -> 0.23.46 (RUSTSEC-2026-0285/0346/0348/0349) - rustls-webpki 0.103.13 -> 0.103.16 (RUSTSEC-2026-0382; pulled by the rustls bump) - quinn-proto 0.11.15 -> 0.11.18 (RUSTSEC-2026-0338/0339/0340/0341/0342) - webpki-root-certs 1.0.7 -> 1.0.10 (RUSTSEC-2026-0383) - crypto-bigint 0.5.5 -> 0.7.10 (RUSTSEC-2026-0387) - ctutils 0.4.2 -> 0.4.8 (RUSTSEC-2026-0385; 0.4.8 also satisfies crypto-bigint 0.7.10) crypto-bigint 0.5.x has no fix (0.7.6 is yanked; the fixed line is 0.7.x), and it was pinned to 0.5.5 by sigstore 0.14 -> openidconnect 4.0 -> p256 0.13 -> elliptic-curve 0.13. Reaching the fix needed sigstore 0.14.0 -> 0.15.0 (the only direct-dep req change) + openidconnect 4.0.1 -> 4.1.0 + hybrid-array 0.4.12 -> 0.4.15, which pull p256 0.14 / elliptic-curve 0.14 / ecdsa 0.17 / ed25519-dalek 3 / curve25519-dalek 5 and crypto-bigint 0.7.10. No application code changed; the engine builds and all 1292 tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013cYVqzH7Xfwea7fAozdQK7
async-trait adds #[must_use] to the desugared future, which clippy already treats as must-use, so `double_must_use` fires on every #[async_trait] impl in the lib crate (11 sites). The lint is a false positive on generated code; allow it crate-wide rather than annotate each generated site. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013cYVqzH7Xfwea7fAozdQK7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
testCI job's Audit dependencies step (cargo audit --ignore RUSTSEC-2023-0071) has been red repo-wide (onmainand every PR): 13 vulnerabilities fire on transitive deps. This blocks unrelated feature PRs (#354) from merging.What
Every advisory had a reachable fix, so this bumps rather than ignores — no new
.cargo/audit.tomlentries. Lockfile-only, except one direct-dep version req inengine/Cargo.toml(sigstore 0.14.0 -> 0.15.0).The crypto-bigint chain
crypto-bigint0.5.x has no fix (0.7.6 is yanked; the fixed line is 0.7.x), and it was pinned to 0.5.5 bysigstore 0.14 -> openidconnect 4.0 -> p256 0.13 -> elliptic-curve 0.13. Reaching the fix neededsigstore 0.14.0 -> 0.15.0(the only direct-dep req change) +openidconnect 4.0.1 -> 4.1.0+hybrid-array 0.4.12 -> 0.4.15, which pullp256 0.14/elliptic-curve 0.14/ecdsa 0.17/ed25519-dalek 3/curve25519-dalek 5andcrypto-bigint 0.7.10. No application code changed.Verification
cargo audit --ignore RUSTSEC-2023-0071: exit 0 (0 vulnerabilities; the 5 remaining warnings are unmaintained/unsound/yanked, warning-class, and do not fail CI)cargo check --workspace: cleancargo nextest run: 1292 passed, 4 skippedcargo fmt --check: cleancargo clippy --all-targets -- -D warnings: pre-existingdouble_must_useerrors from theasync_traitmacro under the newer clippy toolchain — present onmain,async-traitis byte-identical tomain, and not introduced by these dep bumps.🤖 Generated with Claude Code
https://claude.ai/code/session_013cYVqzH7Xfwea7fAozdQK7