fix: require complete circuit test and verifier selections - #1937
Closed
hmzakhalid wants to merge 2 commits into
Closed
hmzakhalid wants to merge 2 commits into
hmzakhalid wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes audit findings GATE-001 and CR-020.
Verification: the new verifier controls reproduced four failures before the fix and all seven pass afterward.
pnpm noir:testpassed 157 library plus 7 recursive-decryption tests (the baseline ran only 157). All six existing artifact controls and both Noir runner controls pass. The newpnpm test:noir-runnerentry point also passed directly. Normal pre-push checks include a real check of the two committed verifiers.The new commands and documentation merge cleanly with the inspected PR #1931 head, preserving its added proof-test lanes. Git merge checks do not replace runtime verification of a combined branch.
No circuit, verifier contract, or cryptographic input format changes.