fix: keep BondedVotes snapshots checkpointed - #1933
Open
hmzakhalid wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedNext included review available in 27 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BondedVotes.getPastVotesfrom adding the token-level lock schedule becauselockedBalanceAtis present-state, not checkpointed history.getVotesso live reads still account for encumbered FOLD under an escrow votes source.PENDINGinto a real policy, and update the voting invariants/flow trace.Verification
pnpm --dir packages/interfold-contracts test test/Registry/BondedVotes.spec.tspnpm exec prettier --check packages/interfold-contracts/contracts/registry/BondedVotes.sol packages/interfold-contracts/test/Registry/BondedVotes.spec.ts agent/INVARIANTS.md agent/flow-trace/02_TOKENS_AND_ACTIVATION.mdpnpm check:docspnpm --dir packages/interfold-contracts lintgit push -u origin fix/voting-issueafterpnpm build:circuits --preset insecure-512 --committee minimum --skip-if-built