Fix weapon skills bug: prevent casting without weapon #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevents weapon-based skills from being cast without a weapon equipped.
Problem
Players could exploit weapon skills (like Twisting Slash) by casting them without a weapon, potentially causing unexpected behavior or exploits.
Solution
Added a check in
AreaSkillAttackAction.PerformAutomaticHitsAsync()that validates weapon presence for skills withMovesToTarget = true.Changes
skill.MovesToTargetproperty instead of hardcoding skill number 41Code Change