-
Notifications
You must be signed in to change notification settings - Fork 141
Add PHP 8.5 support #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v5
Are you sure you want to change the base?
Add PHP 8.5 support #404
Conversation
| if [[ "${PHP_VERSION}" == "8.4" ]]; then | ||
| echo "-- PHP8.4 not support yet blackfire : https://support.blackfire.platform.sh/hc/en-us/articles/4740726712082-PHP-versions-Platforms-support" | ||
| if [[ "${PHP_VERSION}" == "8.4" ]] || [[ "${PHP_VERSION}" == "8.5" ]]; then | ||
| echo "-- PHP${PHP_VERSION} not support yet blackfire : https://support.blackfire.platform.sh/hc/en-us/articles/4740726712082-PHP-versions-Platforms-support" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Blackfire updated the documentation : they said that is supported including 8.4 and 8.5
| - *ev* is not available in PHP 8.1+ | ||
| - *rdkafka* and *snmp* are not available in all `ARM64` images (build time is too long : it's possible to install manually as required) | ||
| - *blackfire* not supported yet in PHP8.4 : https://support.blackfire.platform.sh/hc/en-us/articles/4740726712082-PHP-versions-Platforms-support | ||
| - *blackfire* not supported yet in PHP8.4+ : https://support.blackfire.platform.sh/hc/en-us/articles/4740726712082-PHP-versions-Platforms-support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: That is no more true https://support.blackfire.platform.sh/hc/en-us/articles/4740726712082-PHP-versions-Platforms-support
|
Thx a lot for your PR. Please may you check the CI and fix it ? From 8.5, opcache is a builtin feature so php${PHP_VERSION}-opcache is no more required. |
From PHP 8.5, opcache is a built-in feature and the php8.5-opcache package doesn't exist. Conditionally include the opcache package only for PHP versions other than 8.5.
Summary
Test plan