test: declare pytest-asyncio as a dev dependency - #100
Merged
Conversation
tests/test_a2a_health.py (#97) uses @pytest.mark.asyncio, but pytest-asyncio was never added to the dev extras, so `make test` on a fresh clone fails those tests with "async def functions are not natively supported" until the plugin is installed by hand. Declare it and pin asyncio_mode explicitly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_a2a_health.py(added in Add short timeout to health checks to prevent sidebar hanging #97) uses@pytest.mark.asyncio, butpytest-asynciowas never declared in thedevextras — a freshpip install -e ".[dev]"+make testfails those 4 async tests until someone installs the plugin by handpytest-asyncio>=0.24todev, and pinsasyncio_mode = "strict"explicitly (matches the plugin's existing default, just makes it explicit)Test plan
🤖 Generated with Claude Code