Responsive grid layout (#6)#22
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63f472bce2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return <Transactions />; | ||
| return ( | ||
| <GridLayout> | ||
| <Transactions /> |
There was a problem hiding this comment.
When /finance/transactions renders at md and above, GridLayout creates 4/6/12 columns but Transactions is the only direct grid item and has no col-span-* class. That leaves the whole form and table squeezed into a single narrow column instead of the full content area it occupied before this change; wrap it in a full-span item or avoid the card grid for this route.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Will be reworked anyways. Ok for now.
| latitude: 48.31, | ||
| longitude: 9.3, |
There was a problem hiding this comment.
The new card is labeled Tübingen, but these coordinates point well southeast of the city; Tübingen is roughly around 48.52, 9.06, so the weather request will fetch conditions for a different area while displaying the Tübingen label. This should be corrected before showing the location on the overview.
Useful? React with 👍 / 👎.
| <div | ||
| className={cx('transition-opacity', phase === 'entered' ? 'opacity-100' : 'opacity-0', className)} | ||
| className={cx( | ||
| 'w-full, h-full', |
There was a problem hiding this comment.
In the overview cards, FadeTransition is rendered directly inside Section, which is a row flex container. Because this string emits w-full, instead of Tailwind's w-full, the transition wrapper does not get width: 100% and can size to its contents, leaving the weather skeleton/header from stretching across the card; use w-full h-full here.
Useful? React with 👍 / 👎.
1 participant
Closes #6