Protect practice hack WRAM against x-ray#261
Draft
idlechild wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can see why this wasn't done earlier. I'd like to handle the left and right use cases, but I'm only half done. The aim up and aim down use cases aren't worth the effort.
At least I'm learning about x-ray corruption. It looks like it is easy to write 00FF over a lot of values in the $7E9800-$7F1800 range. If Y is negative then values can be written in the $7F1800-$7F9800 range (I think). Values other than 00FF can be written representing the cone of the x-ray, but I think it is harder to control; you might only be able to write dozens of those values whereas you can write thousands of 00FF. I'm not an expert though.
This is not intended as a quick update. This isn't blocking anyone from routing any% glitched or 0% or other categories as far as I know. Plan to include in the next proper release.
Spacetime beam protection did not change; I just moved it to a new file.