fix: no await sync events delay scope - #1374
Open
zigzagdev wants to merge 2 commits into
Open
Conversation
… file-wide name match The rule tracked whether a `delay` variable was a positive integer using a single file-scoped flag keyed only on the identifier name, so an unrelated `delay` variable elsewhere in the file could mask a call whose own `delay` was 0, causing the required `await` warning to be silently skipped.
… variable leak Covers the scenario where an unrelated `delay` variable in one test block previously suppressed the await warning for a differently-scoped `delay` variable in another test block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks
Changes
no-await-sync-events: resolve thedelayvariable via scope (ASTUtils.findVariable) instead of matching on the identifier name across the whole file, so an unrelateddelayvariable declared elsewhere in the file no longer suppresses a legitimateawaitwarning.delay = 1000in onetestblock previously masked adelay = 0in another).Context
N/A