fix: wrap filterNode in arrow function to ignore extra callback args#1377
Open
mixelburg wants to merge 1 commit intotesting-library:mainfrom
Open
fix: wrap filterNode in arrow function to ignore extra callback args#1377mixelburg wants to merge 1 commit intotesting-library:mainfrom
mixelburg wants to merge 1 commit intotesting-library:mainfrom
Conversation
.filter(filterNode) passes (element, index, array) to filterNode, but filterNode expects only (node: Node). Wrapping with an arrow function ensures only the element is passed, preventing unexpected behavior when the Array.prototype.filter callback arguments are misinterpreted. Fixes testing-library#1360
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ca964b8:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1360
When printing filtered DOM nodes, Array.prototype.filter passes three arguments (element, index, array) to the callback, but filterNode expects only (node: Node). While this works in JS due to ignored extra arguments, wrapping with an explicit arrow function
.filter(node => filterNode(node))ensures only the element is passed, matching the type signature.