Repository navigation
Fix empty exports for CommonJS modules imported after quibble() - #128
Merged
Merged
Conversation
Fixes #111 On Node 20.6-24.17 and 25.x, Node's ESM loader caches a not-yet-loaded Module for a CommonJS file, loads it through Module._load, and reads the exports off that cached object. doWithoutCache swapped the entry out for a fresh copy and put the empty one back, so import() returned {}. Leave an unloaded cache entry in place and load it there. Already-loaded modules still get a fresh copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111
On Node 20.6-24.17 and 25.x, Node's ESM loader caches a not-yet-loaded Module for a CommonJS file, loads it through Module._load, and reads the exports off that cached object. doWithoutCache swapped the entry out for a fresh copy and put the empty one back, so import() returned {}.
Leave an unloaded cache entry in place and load it there. Already-loaded modules still get a fresh copy.