Conversation
|
So I got stuck with the Port file pulling the pkg-config file from the root repo instead of Would appreciate sanity check @seffradev |
| "license": "MIT", | ||
| "dependencies": [ | ||
| { | ||
| "name": "testcontainers-bridge", |
There was a problem hiding this comment.
That part does not work in vcpkg runs yet, even if local installation is fine.
Likely, the port files are messed up somehow
| IMPORTED_LOCATION ${CMAKE_CURRENT_BINARY_DIR}/${SHIM_TARGET_LIB} | ||
| INTERFACE_INCLUDE_DIRECTORIES ${CMAKE_CURRENT_BINARY_DIR}) | ||
|
|
||
| # Install library and header files |
There was a problem hiding this comment.
I am still not sure about making testcontainers-bridge a separate deliverable, but it seems to be the easiest approach if we want to preserve the project structure. When we get to 1.0, the non-committment on the API should be explicitly documented
There was a problem hiding this comment.
My vision was that testcontainers-bridge would be statically linked (with -fPIC) into testcontainers-c, which would in turn be two targets, a static library, and a dynamic library.
There was a problem hiding this comment.
Yeah. That's easy with CMake. I just need to figure our how to do vcpkg ports in such a case, without breaking the dependency graph. Idea of having 2 packages is very debatable, maysbe I will just do twqo modes in the terstcontainers-c CMake
Initial work for or #2 . It will not enable publishing yet, but at least ther ewill be a stable experimental build