Fallback to amd64 on InternalServerErrorException during image pull#11841
Fallback to amd64 on InternalServerErrorException during image pull#11841Jaiswal-Devpriya wants to merge 2 commits into
Conversation
|
I investigated the failure path reported in #11782 and found that the existing fallback to In the reported case, some registries return an I've updated the fallback logic to also handle |
|
I’m concerned this changes the semantics of all pull-time Those errors are currently retried as possible transient registry/connection failures. With this change, any 500 causes the pull command to be reconfigured with I think the safer fix would be to expose an explicit image platform option and pass it through to |
|
Thanks for the review @MichaelLykkeStrand. I agree with the concern about changing the semantics of all I'll rework the implementation to avoid inferring an amd64 fallback from generic 500 responses and investigate an explicit platform configuration approach that passes through to I'll update the PR once I have a revised implementation and tests in place. |
Jaiswal-Devpriya
left a comment
There was a problem hiding this comment.
Thanks for the feedback. I reworked the approach to avoid inferring an amd64 fallback from generic InternalServerErrorExceptions and to preserve the existing retry semantics for pull failures.
Instead, I added an explicit image platform option that is passed through to PullImageCmd.withPlatform(...), making platform selection opt-in rather than automatically triggered by a pull-time exception.
I've also added test coverage to verify that the configured platform is propagated to the pull command.
No description provided.