[pull] master from robotframework:master #145
Open
+164,409
−43,735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://master-n02a3.squash.io |
Also some refactoring: - Parse arguments to VariableMatch objects just once. - Reorder methods. Fixes #5443.
Hopefully this doesn't make tests flakey...
…yword This only affects a situation where - a name of an executed keyword contains a variable and - the name matches a different keyword depending on are variables replaced or not. After this change an exact match after variables have been resolved has a precedence regardless what the original name would match. Fixes #5444.
- Remind to run `invoke format`. - Enhance Libdoc template generation instructions. - Update the outdated list where to send announcements.
Most importantly, document automatic code formatting. Fixes #5441.
Iterate the file object directly instead. Fixes #5447.
Using `skip` is a bit safer, because forgetting to use `on` would disable formatting for the remaining file. We also mostly use `skip` elsewhere.
Use the formatting style enforced by autoformatters even when formatting is disabled for other reasons.
Separate tests for: - Embedded args as a literal string - Embedded args as a variable
Most importantly, fix regression with French `Étant donné`, `Et` and `Mais` prefixes not working with keyword names starting with `que` or `qu'`. Fixes #5456.
Messages and keywords by the end_test listener method overrode test's body if test had a teardown and JSON output was used. This was due to there being two `body` items in this case. The issue was fixed by merging duplicate JSON items that have lists as values. Fixes #5463. Added teardown to the widely used pass_and_fail.robot file required updating various unrelated tests.
- Match name only with `kw` elements. - Remove dead code related to matching tags. Tags are nowadays handled after parsing output.xml.
- Make generic - Better name
This was already done with `Split To Lines` and `Get Substring`, but now it is also done with `Split String`, `Split String From Right` and `Generate Random String`. Fixes #5537.
Fixes #5568. Also enhance comments about other deprecations in RF 7.4. Now all have a TODO about removing in RF 9. Possibly those that affect signatures (`Literal[""]`) could be removed already earlier, with others there's no real hurry.
Also some fine-tuning.
Earlier no conversion was attempted if argument was typed like `arg: int | object`. Nowadays conversion to types before `object` is attempted. Fixes #5529. We plant to change `Any` conversion this way as well. See #5571 for details. Also simplify `Should Be Equal` typing. The old approach would have caused issues if `Any` handling was changed.
These types are used with keywords executing other keywords to type names and arguments of the executed keywords, respectively. External tools can recognize arguments using these types and handle them accordingly. Fixes #4857.
- Fix explanation about normalizing full names. Fixes #5573. - Clarify documentation in general.
Shorter timeouts and sleeping times. This kind of changes are a bit risky, because they can make tests flakey. In this case changes should make tests more stable, though, because the default test timeout has been increased. Even if a test would be slow on some run (e.g. due to OS), it should not hit the new 10s timeout.
Try to avoid flakeyness
Motivation is moving ProcessResult before Process to be able to give custom type documentation to it (#5575).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )