-
Notifications
You must be signed in to change notification settings - Fork 3
fix: update required_providers version #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Aashiq-J
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will need to update the versions of the restapi provider in the modules as well.
ignore_all_server_changes = true you will need to set this parameter for the resource "restapi_object" "storage_delegation" and resource "restapi_object" "configure_project".
This will prevent the restapi call from making any server changes during the consequent terraform plan.
…gnore server changes
|
@Aashiq-J I tried updating the versions in modules and added the variable, the terraform validation is failing and upgrade tests are. still failing Terraform validate upgrade tests |
Co-authored-by: Aashiq Jacob <122446118+Aashiq-J@users.noreply.github.com>
Co-authored-by: Aashiq Jacob <122446118+Aashiq-J@users.noreply.github.com>
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the provider version in the examples too
|
/run pipeline |
|
@HarikaPonna The upgrade test is failing because it has detected |
Co-authored-by: Aashiq Jacob <122446118+Aashiq-J@users.noreply.github.com>
Co-authored-by: Aashiq Jacob <122446118+Aashiq-J@users.noreply.github.com>
Co-authored-by: Aashiq Jacob <122446118+Aashiq-J@users.noreply.github.com>
Co-authored-by: Aashiq Jacob <122446118+Aashiq-J@users.noreply.github.com>
|
/run pipeline |
|
@ocofaigh Yes, this behavior is expected. After upgrading the provider, the error comes from changes in |
|
I approve to skip upgrade test |
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, I just spotted one more issue -> https://github.com/terraform-ibm-modules/terraform-ibm-watsonx-ai/pull/201/files#r2588384845
|
/run pipeline |
|
Unrelated to changes in this Pr, so re-running.. |
|
/run pipeline |
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
… upgrading to this version will see the expected update in place of the `module.watsonx_ai.module.storage_delegation[0].restapi_object.storage_delegation` resource (#201)
Description
This update the ibm and restapi provider versions across the module to align with the latest supported releases
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers