Skip to content

refactor: Update iam_service_id to iam_id #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
+18 −18
Draft

refactor: Update iam_service_id to iam_id #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
901366b
refactor: Update iam_service_id to iam_id
Oct 9, 2025
9ecba96
refactor: Update iam_service_id to iam_id
Oct 9, 2025
24f30ec
Merge branch 'main' into 16337-issue
arya-girish-k Oct 13, 2025
4b8e101
Merge branch 'main' into 16337-issue
arya-girish-k Oct 14, 2025
006162b
Merge branch 'main' into 16337-issue
arya-girish-k Oct 17, 2025
ea79f7f
Merge branch 'main' into 16337-issue
arya-girish-k Nov 20, 2025
6da5508
fix: Updated value
Nov 26, 2025
454d8d5
fix: Resolved pipx issue
Nov 26, 2025
d229c2d
Merge branch 'main' into 16337-issue
arya-girish-k Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common-dev-assets
Open in desktop
Submodule common-dev-assets updated 3 files
+2 −1 commonRenovateConfig.json
+36 −33 module-assets/ci/install-deps.sh
+8 −4 module-assets/ci/validateIbmCatalogJson.py
2 changes: 1 addition & 1 deletion examples/all-combined/imagepull-apikey-secrets-manager/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This module generate and store a service ID API key in IBM Cloud Secrets Manager
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= v1.0.0 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.51.0, < 2.0.0 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.83.0, < 2.0.0 |
| <a name="requirement_time"></a> [time](#requirement\_time) | >= 0.9.1, < 1.0.0 |

### Modules
Expand Down
4 changes: 2 additions & 2 deletions examples/all-combined/imagepull-apikey-secrets-manager/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ resource "ibm_iam_service_id" "image_secret_pull_service_id" {
resource "ibm_iam_service_policy" "cr_policy" {


iam_service_id = ibm_iam_service_id.image_secret_pull_service_id.id
roles = ["Reader"]
iam_id = ibm_iam_service_id.image_secret_pull_service_id.iam_id
roles = ["Reader"]

resources {
service = "container-registry"
Expand Down
2 changes: 1 addition & 1 deletion examples/all-combined/imagepull-apikey-secrets-manager/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
# Use "greater than or equal to" range in modules
ibm = {
source = "IBM-Cloud/ibm"
version = ">= 1.51.0, < 2.0.0"
version = ">= 1.83.0, < 2.0.0"
}
time = {
source = "hashicorp/time"
Expand Down
4 changes: 2 additions & 2 deletions examples/all-combined/secretsmanager.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ resource "ibm_iam_service_id" "secret_puller" {

# Create policy to allow new service id to pull secrets from secrets manager
resource "ibm_iam_service_policy" "secret_puller_policy" {
iam_service_id = ibm_iam_service_id.secret_puller.id
roles = ["Viewer", "SecretsReader"]
iam_id = ibm_iam_service_id.secret_puller.iam_id
roles = ["Viewer", "SecretsReader"]

resources {
service = "secrets-manager"
Expand Down
2 changes: 1 addition & 1 deletion examples/all-combined/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ terraform {
}
ibm = {
source = "IBM-Cloud/ibm"
version = ">= 1.62.0"
version = ">= 1.83.0"
}
null = {
source = "hashicorp/null"
Expand Down
4 changes: 2 additions & 2 deletions examples/basic/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,8 @@ resource "ibm_iam_service_id" "secret_puller" {

# Create policy to allow new service id to pull secrets from secrets manager
resource "ibm_iam_service_policy" "secret_puller_policy" {
iam_service_id = ibm_iam_service_id.secret_puller.id
roles = ["Viewer", "SecretsReader"]
iam_id = ibm_iam_service_id.secret_puller.iam_id
roles = ["Viewer", "SecretsReader"]

resources {
service = "secrets-manager"
Expand Down
2 changes: 1 addition & 1 deletion examples/basic/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ terraform {
}
ibm = {
source = "IBM-Cloud/ibm"
version = "= 1.79.2"
version = "= 1.83.0"
}
null = {
source = "hashicorp/null"
Expand Down
14 changes: 7 additions & 7 deletions solutions/fully-configurable/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,9 @@ locals {

# Create policy to allow new service id to pull secrets from secrets manager
resource "ibm_iam_service_policy" "cluster_secrets_store_secrets_puller_policy" {
for_each = local.cluster_secrets_stores_policies_to_create_map
iam_service_id = each.value.accountServiceID
roles = ["Viewer", "SecretsReader"]
for_each = local.cluster_secrets_stores_policies_to_create_map
iam_id = each.value.accountServiceID
roles = ["Viewer", "SecretsReader"]
resources {
service = "secrets-manager"
resource_instance_id = local.sm_guid
Expand Down Expand Up @@ -511,7 +511,7 @@ locals {
for secrets_store_key, secrets_store in var.eso_secretsstores_configuration.secrets_stores :
secrets_store_key => {
# if the existing_serviceid_id is null it collects the service id created otherwise will use the existing one
"accountServiceID" : (secrets_store.existing_serviceid_id == null || secrets_store.existing_serviceid_id == "") ? ibm_iam_service_id.secrets_stores_secret_puller[secrets_store_key].id : secrets_store.existing_serviceid_id
"accountServiceID" : (secrets_store.existing_serviceid_id == null || secrets_store.existing_serviceid_id == "") ? ibm_iam_service_id.secrets_stores_secret_puller[secrets_store_key].iam_id : secrets_store.existing_serviceid_id
"service_secrets_groups_IDs" : local.secrets_stores_service_secrets_groups_fulllist[secrets_store_key]
}
})
Expand All @@ -537,9 +537,9 @@ locals {

# Create policy to allow new service id to pull secrets from secrets manager
resource "ibm_iam_service_policy" "secrets_store_secrets_puller_policy" {
for_each = local.secrets_stores_policies_to_create_map
iam_service_id = each.value.accountServiceID
roles = ["Viewer", "SecretsReader"]
for_each = local.secrets_stores_policies_to_create_map
iam_id = each.value.accountServiceID
roles = ["Viewer", "SecretsReader"]
resources {
service = "secrets-manager"
resource_instance_id = local.sm_guid
Expand Down