feat(vm): Add blueprint metadata for compute_instance module #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Umm-E-Kulsum
requested review from
a team,
ayushmjain,
erlanderlo and
q2w
as code owners
bharathkkb
requested changes
Nov 21, 2025
Member
bharathkkb
left a comment
bharathkkb
left a comment
There was a problem hiding this comment.
Lets not check in the lock file
bharathkkb
approved these changes
Nov 24, 2025
Member
bharathkkb
left a comment
bharathkkb
left a comment
There was a problem hiding this comment.
@q2w can you take a look for metdata?
ayushmjain
reviewed
Nov 26, 2025
| sourceType: git | ||
| dir: /modules/compute_instance | ||
| version: 13.6.1 | ||
| version: 13.6.3 |
Collaborator
There was a problem hiding this comment.
why are we changing this version here?
ayushmjain
reviewed
Nov 26, 2025
| - name: instances_details | ||
| description: List of all details for compute instances | ||
| type: | ||
| - tuple |
Collaborator
There was a problem hiding this comment.
should this be list instead of tuple? Same comment for other places where tuple is being used
ayushmjain
reviewed
Nov 26, 2025
| enable_vtpm: bool | ||
| source_instance_template: string | ||
| tags: | ||
| - set |
Collaborator
There was a problem hiding this comment.
should this be list instead of set? Same comment for other places where set is used
ayushmjain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.