Fix ICE in label_fn_like for splatted args and add UI tests#1
Closed
Ajay-singh1 wants to merge 2 commits into
Closed
Fix ICE in label_fn_like for splatted args and add UI tests#1Ajay-singh1 wants to merge 2 commits into
label_fn_like for splatted args and add UI tests#1Ajay-singh1 wants to merge 2 commits into
Conversation
teor2345
reviewed
Jun 4, 2026
Owner
There was a problem hiding this comment.
Thanks for this PR, it looks good!
I'd like to do a detailed review, but that would be better at rust-lang/rust, so other reviewers can see it.
It will also run the full CI suite.
Can you open a draft PR with this branch at https://github.com/rust-lang/rust/pulls ?
Please say in the description that it's based on rust-lang#153697
Here's an example of another PR that's based on that PR:
rust-lang#155852
Author
|
Sure!
…On Thu, 4 Jun, 2026, 3:39 pm teor, ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for this PR, it looks good!
I'd like to do a detailed review, but that would be better at
rust-lang/rust, so other reviewers can see it.
It will also run the full CI suite.
Can you open a draft PR with this branch at
https://github.com/rust-lang/rust/pulls ?
Please say in the description that it's based on rust-lang#153697
<rust-lang#153697>
Here's an example of anotjer PR that's based on that PR:
rust-lang#155852 <rust-lang#155852>
—
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AI7B2GBVV2TNNTO4FDPLVUL46FDFRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSGY4DKOJYGMZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4426859833>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7B2GHHPISVVVYHJMEMBO346FDFRAVCNFSM6AAAAACZYQ7C7KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DIMRWHA2TSOBTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
Closing this one in favour of rust-lang#157434 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of rust-lang#153697 (teor's
#[splat]implementation).Bug Fix
While writing UI tests for the unhappy path of the
overload-at-homeexample, I discovered an ICE when calling a splatted function with an argument combination that has no registered impl:The condition
!tuple_arguments.is_splatted()inlabel_fn_likewas inverted , the safeuse_splat_fallbackpath ran for non-splatted functions, and thespan_bug!fired for splatted ones. Fix is removing the!.After the fix the compiler gives a clean error instead:
error[E0308]: mismatched types expected String, found i32