Harden Dockerfile security with non-root user#1031
Open
RinZ27 wants to merge 1 commit intotensorflow:masterfrom
Open
Harden Dockerfile security with non-root user#1031RinZ27 wants to merge 1 commit intotensorflow:masterfrom
RinZ27 wants to merge 1 commit intotensorflow:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Dockerfile to improve security by creating and switching to a non-root user 'tfq-user' and setting the working directory to the user's home. The review feedback suggests explicitly defining the User ID (UID) and Group ID (GID) for the new user to ensure consistency across build environments and prevent potential permission issues with volume mounts.
RinZ27
force-pushed
the
fix/docker-security-hardening
branch
from
8ca7681 to
54e071d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring the module loading logic in
load_module.pyto useexcept Exception:instead of a bareexcept:. Correcting this prevents catching system-level signals likeKeyboardInterrupt, which I noticed was a potential reliability issue in the original implementation.