Skip to content

Add tests for random_symbol_circuit_resolver_batch and random_circuit_resolver_batch #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mhucka wants to merge 1 commit into
base: master
Choose a base branch
from
+31 −0
Draft

Add tests for random_symbol_circuit_resolver_batch and random_circuit_resolver_batch #1029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions tensorflow_quantum/python/util_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,37 @@ def test_get_circuit_symbols_error(self):
'cirq.Circuit'):
util.get_circuit_symbols(param)

def test_random_circuit_resolver_batch(self):
"""Confirm that random_circuit_resolver_batch works."""
qubits = cirq.GridQubit.rect(1, 2)
batch_size = 5
circuits, resolvers = util.random_circuit_resolver_batch(
qubits, batch_size)
self.assertEqual(len(circuits), batch_size)
self.assertEqual(len(resolvers), batch_size)
for circuit in circuits:
self.assertIsInstance(circuit, cirq.Circuit)
Comment on lines +439 to +440
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This test can be made more robust by also verifying that the generated circuits are not empty and do not contain any symbols, which is part of the function's contract.

Suggested change
for circuit in circuits:
self.assertIsInstance(circuit, cirq.Circuit)
for circuit in circuits:
self.assertIsInstance(circuit, cirq.Circuit)
self.assertGreater(len(circuit), 0, "Generated circuit should not be empty.")
self.assertEqual(len(util.get_circuit_symbols(circuit)), 0, "Circuit should not have symbols.")

for resolver in resolvers:
self.assertIsInstance(resolver, cirq.ParamResolver)
self.assertEqual(len(resolver.param_dict), 0)

def test_random_symbol_circuit_resolver_batch(self):
"""Confirm that random_symbol_circuit_resolver_batch works."""
qubits = cirq.GridQubit.rect(1, 2)
symbols = [sympy.Symbol('a'), sympy.Symbol('b')]
batch_size = 5
circuits, resolvers = util.random_symbol_circuit_resolver_batch(
qubits, symbols, batch_size)
self.assertEqual(len(circuits), batch_size)
self.assertEqual(len(resolvers), batch_size)
for circuit in circuits:
self.assertIsInstance(circuit, cirq.Circuit)
Comment on lines +454 to +455
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This test should also verify that the generated circuits contain the expected symbols. This is a key part of the function's contract, and the current test only checks the type of the circuit.

Suggested change
for circuit in circuits:
self.assertIsInstance(circuit, cirq.Circuit)
for circuit in circuits:
self.assertIsInstance(circuit, cirq.Circuit)
extracted_symbols = util.get_circuit_symbols(circuit)
expected_symbols = sorted([str(s) for s in symbols])
self.assertListEqual(expected_symbols, sorted(extracted_symbols))

for resolver in resolvers:
self.assertIsInstance(resolver, cirq.ParamResolver)
self.assertEqual(len(resolver.param_dict), len(symbols))
for symbol in symbols:
self.assertIn(symbol, resolver.param_dict)


class ExponentialUtilFunctionsTest(tf.test.TestCase):
"""Test that Exponential utility functions work."""
Expand Down
Loading