Add tests for channels for util.py's gate_approx_eq#1028
Open
mhucka wants to merge 3 commits intotensorflow:masterfrom
Open
Add tests for channels for util.py's gate_approx_eq#1028mhucka wants to merge 3 commits intotensorflow:masterfrom
gate_approx_eq#1028mhucka wants to merge 3 commits intotensorflow:masterfrom
Conversation
`gate_approx_eq` in `tensorflow_quantum/python/util.py` had logic to handle quantum channels via `_channel_approx_eq`, but this path was not tested in `util_test.py`. This PR adds tests for the following scenarios: - All supported channels: `DepolarizingChannel`, `AsymmetricDepolarizingChannel`, `GeneralizedAmplitudeDampingChannel`, `AmplitudeDampingChannel`, `ResetChannel`, `PhaseDampingChannel`, `PhaseFlipChannel`, and `BitFlipChannel`. - Exact equality for each channel type. - Approximate equality within and outside the `atol` tolerance. - Type mismatches between different channels and between channels and non-channel gates.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new test suite for verifying the approximate equality of various quantum channels and modifies an existing error message's string formatting. Feedback suggests reverting the string formatting change to use f-strings for better readability and refactoring the new test method to reduce code duplication by using a parameterized approach with self.subTest.
Update error message, and streamline test code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gate_approx_eqintensorflow_quantum/python/util.pyhad logic to handle quantum channels via_channel_approx_eq, but this path was not tested inutil_test.py.This PR adds tests for the following scenarios:
All supported channels:
DepolarizingChannel,AsymmetricDepolarizingChannel,GeneralizedAmplitudeDampingChannel,AmplitudeDampingChannel,ResetChannel,PhaseDampingChannel,PhaseFlipChannel, andBitFlipChannel.Exact equality for each channel type.
Approximate equality within and outside the
atoltolerance.Type mismatches between different channels and between channels and non-channel gates.
Note: this PR was created with the help of Jules.