Add pattern to .geminiignore for Emacs versioned backups#1023
Open
mhucka wants to merge 1 commit intotensorflow:masterfrom
Open
Add pattern to .geminiignore for Emacs versioned backups#1023mhucka wants to merge 1 commit intotensorflow:masterfrom
.geminiignore for Emacs versioned backups#1023mhucka wants to merge 1 commit intotensorflow:masterfrom
Conversation
The addition of the pattern `*.~*~` (for Emacs versioned backups) _shouldn't_ be necessary because the file names _should_ be covered by `*~` in our `.gitignore` file, but Gemini CLI currently doesn't seem to interpret `*~` that way. So, an addition to `.geminiignore` is needed to make Gemini CLI ignore Emacs versioned backups.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the .geminiignore file to explicitly ignore Emacs versioned backups, addressing a limitation in how the Gemini CLI interprets standard ignore patterns. Feedback was provided to refine the accompanying comment for better clarity and conciseness by removing conversational language and non-standard markdown emphasis.
mhucka
changed the title
.geminiignore for Emacs versioned backups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of the pattern
*.~*~(for Emacs versioned backups) shouldn't be necessary because the file names should be covered by*~in our.gitignorefile, but Gemini CLI currently doesn't seem to interpret*~that way. So, an addition to.geminiignoreis needed to make Gemini CLI ignore Emacs versioned backups.