fix: bump mpp-rs to accept standard base64 in WWW-Authenticate#384
Open
fix: bump mpp-rs to accept standard base64 in WWW-Authenticate#384
Conversation
Contributor
|
739ff22 to
d5afd14
Compare
Updates mpp dependency to latest main which includes mpp-rs#149 (lenient base64url decoding) plus the 0.7.0 API refactor. Breaking changes adapted: - estimate_gas now takes (provider, TempoTransactionRequest) instead of 11 separate args — build request inline with a closure - tempo-alloy added as workspace dep for TempoTransactionRequest - reqwest http2_adaptive_window removed (dropped in newer reqwest)
d5afd14 to
9e528f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tempo requestfails against servers that encode therequestfield in theWWW-Authenticateheader using standard base64 (RFC 4648 §4) instead of base64url (RFC 4648 §5):The misleading error occurs because
mpp::parse_www_authenticatefails on the base64-paddedrequestfield before ever reading themethodfield, causing the error to cascade as an empty-string method.Fix
Bumps
mppdependency to includetempoxyz/mpp-rs#149, which makesbase64url_decodelenient — it normalizes standard base64 (+,/,=) to URL-safe alphabet before decoding, matching the mppx TypeScript SDK behavior.Verified
Before:
E_PAYMENT: "Unsupported payment method: "After (dry-run):
All tests pass (
make test).Note
Once
mpp-rs#149is merged tomain, this branch ref should be updated fromfix/lenient-base64-decode-v0.5back tomain.