add time-skipping configuration to UpdateWorkflowExecutionOptions#9944
Open
feiyang3cat wants to merge 2 commits intotemporalio:mainfrom
Open
add time-skipping configuration to UpdateWorkflowExecutionOptions#9944feiyang3cat wants to merge 2 commits intotemporalio:mainfrom
UpdateWorkflowExecutionOptions#9944feiyang3cat wants to merge 2 commits intotemporalio:mainfrom
Conversation
feiyang3cat
force-pushed
the
ts/config-2-new
branch
from
1b8b155 to
311214e
Compare
feiyang3cat
changed the title
UpdateWorkflowExecutionOptions
feiyang3cat
commented
Apr 14, 2026
| nil, // priority | ||
| nil, // timeSkippingConfig | ||
| ) | ||
| return api.UpdateWorkflowWithoutWorkflowTask, err |
Contributor
Author
There was a problem hiding this comment.
use existing execution on wfID conflict doesn't involve ts config changes
feiyang3cat
force-pushed
the
ts/config-2-new
branch
6 times, most recently
from
0330cd8 to
9fd5698
Compare
feiyang3cat
force-pushed
the
ts/config-2-new
branch
from
9fd5698 to
4128a4a
Compare
feiyang3cat
commented
Apr 14, 2026
| case enumspb.EVENT_TYPE_WORKFLOW_EXECUTION_OPTIONS_UPDATED: | ||
| if isDuplicate(event) { | ||
| continue | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Q: is this NDC still in use in Cloud when all replication is state based
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Frontend validation — validateTimeSkippingConfig is now invoked in:
Persistence
Events
Why?
Support update feature of time-skipping.
How did you test it?