Open
Conversation
simvlad
force-pushed
the
enable-external-payloads
branch
2 times, most recently
from
ea2893d to
a6aa45a
Compare
yycptt
reviewed
Apr 13, 2026
Member
yycptt
left a comment
yycptt
left a comment
There was a problem hiding this comment.
Is it safe to downgrade to 1.30 with this feature flag enabled?
Contributor
Author
|
Yes, it just enables the payload stats on the workflow execution. Not sure though, why tests are failing |
yycptt
approved these changes
Apr 14, 2026
Member
🤔 maybe rebase? |
Contributor
Author
|
I think it's a bug in #9664, where search attributes in registerTestSearchAttributes are registered for each clusters independently, but the code in addSearchAttributes is non-deterministic. I asked Alan to fix |
simvlad
force-pushed
the
enable-external-payloads
branch
from
a6aa45a to
a239abb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Enable server support for external payloads stats by default
Why?
https://docs.temporal.io/external-storage is in pre-release and available to anyone who wants to try it out from SDK. The server support for collecting the stats is gated by history.externalPayloadsEnabled dynamic config. Enable it by default, as otherwise the executions stats won't be available.
How did you test it?
Potential risks
The change enables the collection of workflow execution stats for external storage, but it is only when the users try out the pre-release feature. So in the case of problems, they can turn the dynamic config off.