[Scheduled Actions] Clean up task validation logic #8951
+326
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Jan 7, 2026
lina-temporal
force-pushed
the
chasm-cleanup-sched-tasks
branch
from
d1a995a to
0aceb11
Compare
yycptt
approved these changes
Jan 7, 2026
Member
yycptt
left a comment
yycptt
left a comment
There was a problem hiding this comment.
not super familiar with the buffered start logic but the rest LGTM.
| } | ||
| scheduler.Backfillers[id] = chasm.NewComponentField(ctx, backfiller) | ||
|
|
||
| backfiller.scheduleTask(ctx, chasm.TaskScheduledTimeImmediate) |
Member
There was a problem hiding this comment.
just checking, using chasm.TaskScheduledTimeImmediate or not give the same behavior right?
Contributor
Author
There was a problem hiding this comment.
Yep, same behavior, and backfills reschedule themselves at particular points of time when backing off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
How did you test it?