Skip to content

fix(controller): watch Connection to clear stale TemporalConnection status #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaypipes merged 1 commit into from
Aug 31, 2026
+6 −0
Merged

fix(controller): watch Connection to clear stale TemporalConnection status #545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/controller/deprecated_tc_reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/handler"
)

// +kubebuilder:rbac:groups=temporal.io,resources=temporalconnections,verbs=get;list;watch;update;patch
Expand Down Expand Up @@ -110,6 +111,11 @@ func (r *DeprecatedTCReconciler) Reconcile(ctx context.Context, req ctrl.Request
func (r *DeprecatedTCReconciler) SetupWithManager(mgr ctrl.Manager) error {
return ctrl.NewControllerManagedBy(mgr).
For(&temporaliov1alpha1.TemporalConnection{}).
// A Connection is the replacement for the same-named TemporalConnection,
// so creating one changes the deprecated resource's status. Without this
// watch that status stays stale until an unrelated event happens to
// trigger a reconcile.
Watches(&temporaliov1alpha1.Connection{}, &handler.EnqueueRequestForObject{}).
Named("deprecated-tc").
Complete(r)
}
Loading