Skip to content

Clarify determinism of wait_condition with comment #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sushisource merged 2 commits into from
Jul 15, 2026
+5 −0
Merged

Clarify determinism of wait_condition with comment #1638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
425031c
Clarify determinism of wait_condition with comment
Sushisource Jul 10, 2026
f66401c
Make 0 make more sense
Sushisource Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions temporalio/workflow/_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,11 @@ async def wait_condition(
This function returns when the callback returns true (invoked each loop
iteration) or the timeout has been reached.

Importantly, using `None` value for ``timeout`` means that no Temporal timer is created. This
means changing from `None` to a positive value (or the inverse) constitutes a nondeterministic
change to workflow code. Using ``0`` will cause this function to immediately throw a timeout and
should not be used.

Args:
fn: Non-async callback that accepts no parameters and returns a boolean.
timeout: Optional number of seconds to wait until throwing
Expand Down
Loading