Drop old package versions that predate PHP 8.1 requirement - #792
Open
sachinsharma3191 wants to merge 4 commits into
Open
Drop old package versions that predate PHP 8.1 requirement#792sachinsharma3191 wants to merge 4 commits into
sachinsharma3191 wants to merge 4 commits into
Conversation
added 4 commits
August 11, 2026 18:12
Remove version ranges for packages that support PHP 7.x/8.0: - nesbot/carbon: drop ^2.72.6 (PHP 7.4+), keep ^3.8.4 (PHP 8.1+) - symfony/filesystem: drop ^5.4.45 (PHP 7.2.5+), keep ^6.4.13+ - symfony/http-client: drop ^5.4.53 (PHP 7.2.5+), keep ^6.4.17+ - symfony/process: drop ^5.4.51 (PHP 7.2.5+), keep ^6.4.15+ Closes temporalio#698
The validate-prefer-lowest check fails because the declared minimums (6.4.13 for filesystem, 6.4.15 for process) cannot be installed with --prefer-lowest due to transitive dependency constraints. Updated to the actual lowest resolvable versions (6.4.24 and 6.4.33).
The dload binary downloader uses GitHub API to find and download release assets for RoadRunner, Temporal CLI, and Temporal test server. When many CI jobs run concurrently, the 5000 req/hr rate limit is exhausted causing widespread failures. Cache the extracted binaries keyed on the dload.xml configuration hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Removed version ranges for packages that only exist to support PHP 7.x/8.0, which the SDK no longer requires (
"php": ">=8.1"):nesbot/carbon: drop^2.72.6(PHP 7.4+), keep^3.8.4(PHP 8.1+)symfony/filesystem: drop^5.4.45(PHP 7.2.5+), keep^6.4.13+symfony/http-client: drop^5.4.53(PHP 7.2.5+), keep^6.4.17+symfony/process: drop^5.4.51(PHP 7.2.5+), keep^6.4.15+internal/promise: ^2.12was already dropped in a previous change.Why?
Carrying version ranges for packages that support end-of-life PHP versions adds unnecessary complexity to dependency resolution and may pull in older, less maintained versions. Since the SDK requires PHP 8.1+, these ranges serve no purpose.
Closes #698