feat: make eager activity reservation limit configurable - #789
Open
xepozz wants to merge 2 commits into
Open
Conversation
Add WorkerOptions::$maxEagerActivityReservationsPerWorkflowTask (marshalled as MaxEagerActivityReservationsPerWorkflowTask) exposing sdk-go's per-workflow-task eager-activity reservation cap. Nullable: unset marshals to null so the Go worker.Options *int stays nil and falls back to the default of 3; the builder rejects non-positive values (use withDisableEagerActivities() to disable).
Collaborator
Author
|
Awaits a new RR release, because it requires sdk-go 1.47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added
WorkerOptions::$maxEagerActivityReservationsPerWorkflowTask(marshalledMaxEagerActivityReservationsPerWorkflowTask), nullable → SDK default of 3.Why?
Port of temporalio/sdk-go#2493 — the hardcoded per-workflow-task eager-activity limit of 3 is now configurable.
Checklist
Relates to Make eager activity reservation limit configurable sdk-go#2493. Needs roadrunner-temporal on sdk-go >= v1.47.0 (RR 2025.1.16), else no-op.
How was this tested:
WorkerOptionsTestCase— marshalling, builder, non-positive guard. Unit green.No.