Skip to content

Include WorkflowType in wrapFailure error message#2960

Open
DanielPBak wants to merge 1 commit into
temporalio:mainfrom
DanielPBak:fix/wrapfailure-workflow-type
Open

Include WorkflowType in wrapFailure error message#2960
DanielPBak wants to merge 1 commit into
temporalio:mainfrom
DanielPBak:fix/wrapfailure-workflow-type

Conversation

@DanielPBak

Copy link
Copy Markdown

Summary

  • WorkflowWorker$TaskHandlerImpl.wrapFailure builds a RuntimeException message ("Failure processing workflow task. WorkflowId=..., RunId=..., Attempt=...") when a workflow task fails processing, but omits the workflow type.
  • PollWorkflowTaskQueueResponse (already available on task.getResponse()) carries the workflow type, so this adds WorkflowType= to the message using that existing data — no new lookups or API surface required.
  • This makes the error immediately actionable: today, debugging one of these failures requires a separate lookup (e.g. temporal workflow describe) just to find out which workflow type failed.

Test plan

  • Existing WorkflowWorker/task-handler tests still pass
  • No behavior change other than the added field in the exception message

The "Failure processing workflow task" RuntimeException only included
WorkflowId, RunId, and Attempt, forcing anyone debugging a failure to
look up the workflow type separately. PollWorkflowTaskQueueResponse
already carries the workflow type, so include it directly.
@DanielPBak
DanielPBak requested a review from a team as a code owner July 22, 2026 21:52
@CLAassistant

CLAassistant commented Jul 22, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants