Skip to content

Remove experimental markers from user metadata fields #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laniehei wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove experimental markers from user metadata fields #2958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions temporal-sdk/src/main/java/io/temporal/activity/ActivityOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ public Builder setVersioningIntent(VersioningIntent versioningIntent) {
*
* <p>Default is none/empty.
*/
@Experimental
public Builder setSummary(String summary) {
this.summary = summary;
return this;
Expand Down Expand Up @@ -452,7 +451,6 @@ public VersioningIntent getVersioningIntent() {
return versioningIntent;
}

@Experimental
public String getSummary() {
return summary;
}
Expand Down
3 changes: 0 additions & 3 deletions temporal-sdk/src/main/java/io/temporal/activity/LocalActivityOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.temporal.activity;

import com.google.common.base.Objects;
import io.temporal.common.Experimental;
import io.temporal.common.MethodRetry;
import io.temporal.common.RetryOptions;
import java.time.Duration;
Expand Down Expand Up @@ -167,7 +166,6 @@ public Builder setDoNotIncludeArgumentsIntoMarker(boolean doNotIncludeArgumentsI
*
* <p>Default is none/empty.
*/
@Experimental
public Builder setSummary(String summary) {
this.summary = summary;
return this;
Expand Down Expand Up @@ -279,7 +277,6 @@ public boolean isDoNotIncludeArgumentsIntoMarker() {
return doNotIncludeArgumentsIntoMarker != null && doNotIncludeArgumentsIntoMarker;
}

@Experimental
public String getSummary() {
return summary;
}
Expand Down
3 changes: 0 additions & 3 deletions temporal-sdk/src/main/java/io/temporal/client/WorkflowExecutionDescription.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.temporal.client;

import io.temporal.api.workflowservice.v1.DescribeWorkflowExecutionResponse;
import io.temporal.common.Experimental;
import io.temporal.common.converter.DataConverter;
import io.temporal.payload.context.WorkflowSerializationContext;
import javax.annotation.Nonnull;
Expand All @@ -25,7 +24,6 @@ public WorkflowExecutionDescription(
* <p>Note: Will be decoded on each invocation, so it is recommended to cache the result if it is
* used multiple times.
*/
@Experimental
@Nullable
public String getStaticSummary() {
if (!response.getExecutionConfig().getUserMetadata().hasSummary()) {
Expand All @@ -48,7 +46,6 @@ public String getStaticSummary() {
* <p>Note: Will be decoded on each invocation, so it is recommended to cache the result if it is
* used multiple times.
*/
@Experimental
@Nullable
public String getStaticDetails() {
if (!response.getExecutionConfig().getUserMetadata().hasDetails()) {
Expand Down
4 changes: 0 additions & 4 deletions temporal-sdk/src/main/java/io/temporal/client/WorkflowOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,6 @@ public Builder setStartDelay(Duration startDelay) {
*
* <p>Default is none/empty.
*/
@Experimental
public Builder setStaticSummary(String staticSummary) {
this.staticSummary = staticSummary;
return this;
Expand All @@ -413,7 +412,6 @@ public Builder setStaticSummary(String staticSummary) {
*
* <p>Default is none/empty.
*/
@Experimental
public Builder setStaticDetails(String staticDetails) {
this.staticDetails = staticDetails;
return this;
Expand Down Expand Up @@ -716,12 +714,10 @@ public String getRequestId() {
return links;
}

@Experimental
public String getStaticSummary() {
return staticSummary;
}

@Experimental
public String getStaticDetails() {
return staticDetails;
}
Expand Down
4 changes: 0 additions & 4 deletions temporal-sdk/src/main/java/io/temporal/workflow/ChildWorkflowOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,6 @@ public Builder setVersioningIntent(VersioningIntent versioningIntent) {
*
* <p>Default is none/empty.
*/
@Experimental
public Builder setStaticSummary(String staticSummary) {
this.staticSummary = staticSummary;
return this;
Expand All @@ -322,7 +321,6 @@ public Builder setStaticSummary(String staticSummary) {
*
* <p>Default is none/empty.
*/
@Experimental
public Builder setStaticDetails(String staticDetails) {
this.staticDetails = staticDetails;
return this;
Expand Down Expand Up @@ -534,12 +532,10 @@ public VersioningIntent getVersioningIntent() {
return versioningIntent;
}

@Experimental
public String getStaticSummary() {
return staticSummary;
}

@Experimental
public String getStaticDetails() {
return staticDetails;
}
Expand Down
2 changes: 0 additions & 2 deletions temporal-sdk/src/main/java/io/temporal/workflow/TimerOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.temporal.workflow;

import io.temporal.common.Experimental;
import java.util.Objects;

/** TimerOptions is used to specify options for a timer. */
Expand Down Expand Up @@ -42,7 +41,6 @@ private Builder(TimerOptions options) {
*
* <p>Default is none/empty.
*/
@Experimental
public Builder setSummary(String summary) {
this.summary = summary;
return this;
Expand Down
2 changes: 0 additions & 2 deletions temporal-sdk/src/main/java/io/temporal/workflow/Workflow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1538,7 +1538,6 @@ public static <R> NexusOperationHandle<R> startNexusOperation(Functions.Func<R>
*
* @param details details to set
*/
@Experimental
public static void setCurrentDetails(String details) {
WorkflowInternal.setCurrentDetails(details);
}
Expand All @@ -1548,7 +1547,6 @@ public static void setCurrentDetails(String details) {
*
* @return details of the current workflow
*/
@Experimental
@Nullable
public static String getCurrentDetails() {
return WorkflowInternal.getCurrentDetails();
Expand Down
Loading