Skip to content

Fix WorkerOptions.Builder.isUsingVirtualThreadsOnWorkflowWorker #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geraldw-ai wants to merge 2 commits into
base: main
Choose a base branch
from
+41 −1
Open

Fix WorkerOptions.Builder.isUsingVirtualThreadsOnWorkflowWorker #2957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d68e2e
WorkerOptions.Builder.isUsingVirtualThreadsOnWorkflowWorker was
geraldw-ai Jul 21, 2026
654dd70
Merge branch 'main' into workeroptions-builder-isUsingVirtualThreadsO…
geraldw-ai Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporal-sdk/src/main/java/io/temporal/worker/WorkerOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,7 +1011,7 @@ public String getIdentity() {
}

public boolean isUsingVirtualThreadsOnWorkflowWorker() {
return usingVirtualThreadsOnActivityWorker;
return usingVirtualThreadsOnWorkflowWorker;
}

public boolean isUsingVirtualThreadsOnActivityWorker() {
Expand Down
40 changes: 40 additions & 0 deletions temporal-sdk/src/test/java/io/temporal/worker/WorkerOptionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,46 @@ public void validateAndBuildWithDefaultsIsIdempotentWithPollerBehavior() {
assertNotNull(second.getWorkflowTaskPollersBehavior());
}

@Test
public void setUsingVirtualThreadsEnablesAllWorkers() {
WorkerOptions options = WorkerOptions.newBuilder().setUsingVirtualThreads(true).build();
assertTrue(options.isUsingVirtualThreadsOnWorkflowWorker());
assertTrue(options.isUsingVirtualThreadsOnActivityWorker());
assertTrue(options.isUsingVirtualThreadsOnLocalActivityWorker());
assertTrue(options.isUsingVirtualThreadsOnNexusWorker());
}

@Test
public void perWorkerVirtualThreadOptionsAreIndependent() {
WorkerOptions workflowOnly =
WorkerOptions.newBuilder().setUsingVirtualThreadsOnWorkflowWorker(true).build();
assertTrue(workflowOnly.isUsingVirtualThreadsOnWorkflowWorker());
assertFalse(workflowOnly.isUsingVirtualThreadsOnActivityWorker());
assertFalse(workflowOnly.isUsingVirtualThreadsOnLocalActivityWorker());
assertFalse(workflowOnly.isUsingVirtualThreadsOnNexusWorker());

WorkerOptions activityOnly =
WorkerOptions.newBuilder().setUsingVirtualThreadsOnActivityWorker(true).build();
assertFalse(activityOnly.isUsingVirtualThreadsOnWorkflowWorker());
assertTrue(activityOnly.isUsingVirtualThreadsOnActivityWorker());
assertFalse(activityOnly.isUsingVirtualThreadsOnLocalActivityWorker());
assertFalse(activityOnly.isUsingVirtualThreadsOnNexusWorker());

WorkerOptions localActivityOnly =
WorkerOptions.newBuilder().setUsingVirtualThreadsOnLocalActivityWorker(true).build();
assertFalse(localActivityOnly.isUsingVirtualThreadsOnWorkflowWorker());
assertFalse(localActivityOnly.isUsingVirtualThreadsOnActivityWorker());
assertTrue(localActivityOnly.isUsingVirtualThreadsOnLocalActivityWorker());
assertFalse(localActivityOnly.isUsingVirtualThreadsOnNexusWorker());

WorkerOptions nexusOnly =
WorkerOptions.newBuilder().setUsingVirtualThreadsOnNexusWorker(true).build();
assertFalse(nexusOnly.isUsingVirtualThreadsOnWorkflowWorker());
assertFalse(nexusOnly.isUsingVirtualThreadsOnActivityWorker());
assertFalse(nexusOnly.isUsingVirtualThreadsOnLocalActivityWorker());
assertTrue(nexusOnly.isUsingVirtualThreadsOnNexusWorker());
}

@Test
public void verifyMaxTaskQueuePerSecondsDisablesEagerExecution() {
// Verify that by default eager execution is enabled
Expand Down