Conversation
| "@opentelemetry/exporter-trace-otlp-grpc": "^0.57.2", | ||
| "@opentelemetry/exporter-trace-otlp-http": "^0.57.2", | ||
| "@opentelemetry/exporter-metrics-otlp-grpc": "^0.57.2", | ||
| "@opentelemetry/exporter-metrics-otlp-http": "^0.57.2", | ||
| "@opentelemetry/exporter-prometheus": "^0.57.2", |
There was a problem hiding this comment.
Bumping these as there was a bad release where they did not declare a dependency on base resulting in usage with PNPM (or any other package manager without hoisting) failures.
| export const otelSdk = new NodeSDK({ | ||
| // This is required for use with the `@temporalio/interceptors-opentelemetry` package. | ||
| resource, | ||
| export function setupOtelSdk(): NodeSDK { |
There was a problem hiding this comment.
Need to defer constructing NodeSDK since client now imports from this module.
| "@temporalio/testing": "^1.13.2", | ||
| "@temporalio/nyc-test-coverage": "^1.15.0", | ||
| "@temporalio/testing": "^1.15.0", | ||
| "@tsconfig/node18": "^18.2.4", |
There was a problem hiding this comment.
We should also update these to @tsconfig/node20, with corresponding versions.
There was a problem hiding this comment.
Seems like @types/node are already set to 22.
| const traceExporter = setupTraceExporter(); | ||
|
|
||
| export const spanProcessor: SpanProcessor | undefined = traceExporter | ||
| ? new SimpleSpanProcessor(traceExporter) |
There was a problem hiding this comment.
Should we not recommend the batch processor instead?
| exporter: makeWorkflowExporter(traceExporter, resource), | ||
| }, | ||
| interceptors: traceExporter && { | ||
| // IMPORTANT: When prebundling Workflow code (i.e. using `bundleWorkflowCode(...)`), you MUST |
There was a problem hiding this comment.
We should still have a similar callout, adapted to plugin usage.
| "prepare": "husky install", | ||
| "update-toc": "doctoc README.md" | ||
| "update-toc": "doctoc README.md", | ||
| "verify-samples": "zx .scripts/verify-samples.mjs" |
There was a problem hiding this comment.
Is that a thing? Maybe you forgot to add the file to your commit?
3 participants
What was changed
Why?
Checklist
Closes N/A
How was this tested:
Ran some samples locally that were directly affected by this release (OTEL, AI SDK)
Any docs updates needed?
N/A